Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove temporary particle container #5571

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Jan 17, 2025

Close #5056.

@EZoni EZoni added the cleaning Clean code, improve readability label Jan 17, 2025
@EZoni EZoni force-pushed the remove_tmp_particle_data branch from b4cba13 to ed9b30d Compare January 17, 2025 23:42
@EZoni EZoni force-pushed the remove_tmp_particle_data branch from 2a30289 to 75b7030 Compare January 23, 2025 00:55
@ax3l ax3l requested a review from atmyers January 24, 2025 18:35
@ax3l ax3l self-requested a review January 24, 2025 18:35
@EZoni EZoni marked this pull request as ready for review January 24, 2025 23:45
: m_t_boost(t_boost), m_dt(dt), m_t_lab(t_lab)
{
using namespace amrex::literals;

if (tmp_particle_data.empty()) { return; }
// FIXME

Check notice

Code scanning / CodeQL

FIXME comment Note

FIXME comment
Source/Initialization/WarpXInitData.cpp Fixed Show fixed Hide fixed
{
if (tmp_particle_data.empty()) { return; }
// FIXME

Check notice

Code scanning / CodeQL

FIXME comment Note

FIXME comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Clean code, improve readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Temporary Particle Container tmp_pc
2 participants