-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Remove temporary particle container #5571
Open
EZoni
wants to merge
7
commits into
ECP-WarpX:development
Choose a base branch
from
EZoni:remove_tmp_particle_data
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
force-pushed
the
remove_tmp_particle_data
branch
from
January 17, 2025 23:42
b4cba13
to
ed9b30d
Compare
EZoni
force-pushed
the
remove_tmp_particle_data
branch
from
January 23, 2025 00:55
2a30289
to
75b7030
Compare
EZoni
commented
Jan 23, 2025
: m_t_boost(t_boost), m_dt(dt), m_t_lab(t_lab) | ||
{ | ||
using namespace amrex::literals; | ||
|
||
if (tmp_particle_data.empty()) { return; } | ||
// FIXME |
Check notice
Code scanning / CodeQL
FIXME comment Note
FIXME comment
{ | ||
if (tmp_particle_data.empty()) { return; } | ||
// FIXME |
Check notice
Code scanning / CodeQL
FIXME comment Note
FIXME comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5056.